rustc: Check if def_path_hash_to_def_id is populated before accessing. #42737
Conversation
… it. Without this patch, there is an ICE when running rustc with RUST_LOG=debug. This patch updates extract_def_id to check if the map has been populated before accessing it. This fixes the problem, but maybe we do not need to compute the incremental hashes maps in the first place when we are not in incremental mode?
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
It looks like @michaelwoerister added |
|
@bors r+ Good catch, @fhahn! At the moment we are always building (part of) the incremental hashes map in order to compute the SVH, which as a kind of global hash of a crate's contents and used for various consistency checks. But we may want to review if the last remaining uses of the SVH implemented in a cheaper way after #42677 has been fixed. Originally the SVH was supposed to capture ABI compatibility between crates -- but it has become far more sensitive than that since then. |
|
📌 Commit 8723f28 has been approved by |
rustc: Check if def_path_hash_to_def_id is populated before accessing. Without this patch, there is an ICE when running rustc with RUST_LOG=debug. This patch updates extract_def_id to check if the map has been populated before accessing it. This fixes the problem, but maybe we do not need to compute the incremental hashes maps in the first place when we are not in incremental mode?
|
☀️ Test successful - status-appveyor, status-travis |
Without this patch, there is an ICE when running rustc with
RUST_LOG=debug. This patch updates extract_def_id to check if the map
has been populated before accessing it. This fixes the problem, but
maybe we do not need to compute the incremental hashes maps in the first
place when we are not in incremental mode?